git-hulk commented on PR #3061: URL: https://github.com/apache/kvrocks/pull/3061#issuecomment-3101131354
> I think we can make the frequency of sendReplConfAck configurable, i.e. maybe we can make it called in every N rounds of incrementBatchLoopCB rather than in every incrementBatchLoopCB. (Or, we can introduce a timer so that "every N rounds" can be replaced by "every N seconds/minutes" and then WAIT should be more expectable.) Another approach is like the Redis behavior, which sends `REPLCONF ACK` periodically(every second) in replica, and the master can also send `REPLCONF GETACK` to ask replicas reply the offset ASAP after the WAIT command. > Maybe we can exclude this commit from release 2.13.0 so that we can improve it without considering to avoid breaking changes? And from me it's fine to include https://github.com/apache/kvrocks/commit/b81434f38b470df8a65bf9f987fdcbd7c04cf07a since there's much less performance impact and didn't introduce new kvrocks-specific commands (replconf ack). cc @git-hulk @LindaSummer +1 to include https://github.com/apache/kvrocks/commit/b81434f38b470df8a65bf9f987fdcbd7c04cf07a. Another potential issue is the WAIT command will be pending forever if any replicas don't support the `REPLCONF ACK`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
