LindaSummer commented on PR #3061: URL: https://github.com/apache/kvrocks/pull/3061#issuecomment-3101149455
> Thank you for replying. An issue is created to track this. > > Several points from mine mind: > > 1. I think we can make the frequency of `sendReplConfAck` configurable, i.e. maybe we can make it called in every N rounds of `incrementBatchLoopCB` rather than in every `incrementBatchLoopCB`. (Or, we can introduce a timer so that "every N rounds" can be replaced by "every N seconds/minutes" and then `WAIT` should be more expectable.) > > 2. TODO > > 3. Maybe we can exclude this commit from release 2.13.0 so that we can improve it without considering to avoid breaking changes? And from me it's fine to include [b81434f](https://github.com/apache/kvrocks/commit/b81434f38b470df8a65bf9f987fdcbd7c04cf07a) since there's much less performance impact and didn't introduce new kvrocks-specific commands (`replconf ack`). cc @git-hulk @LindaSummer Hi @PragmaTwice , @git-hulk , Got it! 😊 I'll exclude this commit and include b81434f in release 2.13.0. Best Regards, Edward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
