zhixinwen commented on PR #3061: URL: https://github.com/apache/kvrocks/pull/3061#issuecomment-3101171014
> +1 to include [b81434f](https://github.com/apache/kvrocks/commit/b81434f38b470df8a65bf9f987fdcbd7c04cf07a). Another potential issue is the WAIT command will be pending forever if any replicas don't support the `REPLCONF ACK`. @PragmaTwice @git-hulk I think it would be an issue if you release [b81434f](https://github.com/apache/kvrocks/commit/b81434f38b470df8a65bf9f987fdcbd7c04cf07a) first then ack based replication later. Once [b81434f](https://github.com/apache/kvrocks/commit/b81434f38b470df8a65bf9f987fdcbd7c04cf07a) is released, people can begin to use WAIT command. And when they upgrade to the version with ack, they may see the issue you mentioned during the upgrade time. If [b81434f](https://github.com/apache/kvrocks/commit/b81434f38b470df8a65bf9f987fdcbd7c04cf07a) is not released, there would be noone able to use WAIT anyway, so the issue above should not exist. When do you plan to release 2.13.0, I can try to reduce the impact before the release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
