nhancdt2602 commented on PR #3557: URL: https://github.com/apache/kvrocks/pull/3557#issuecomment-4988668284
> @nhancdt2602 Sorry, I’m late. > > > @jihuayu Thanks for your reply. To fix points 2 and 3, can I keep the stats entry in the namespace map even after the namespace is deleted? This would be consistent with the current behavior of db_scan_infos_ > > I have no objection to that, since deleting a namespace is a low-frequency operation. > > What I meant is that this command should not be restricted to ADMIN users. Namespace users are not ADMIN users, so they would be unable to retrieve latency information. @jihuayu Regarding point 1, LATENCY command already is scoped to ADMIN before this PR. If I'm not mistaken, you want to relax it by removing admin flag in LATENCY command config in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
