nhancdt2602 commented on PR #3557: URL: https://github.com/apache/kvrocks/pull/3557#issuecomment-4989336279
@jihuayu I've addressed all three points from your review. Looking for your feedback when you I have time. 1. `latency command is admin only` -> remove admin tag from LATENCY command 2. `Deleting a namespace does not disconnect existing connections. This causes the old connections’ ns_stats_ references to diverge.` -> keep the stats entry in the map without deleting it. 3. `Deleting a namespace may cause an underflow here` -> solved by not deleting stats from the map. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
