git-hulk commented on PR #3557:
URL: https://github.com/apache/kvrocks/pull/3557#issuecomment-5011541254

   @nhancdt2602 It seems only the calls/latency are related to the namespace, 
so I'm wondering if it's better to extend the existing functions in `stats`:
   
   ```C++
   void IncrCalls(const string &ns, const string &cmd) {
     stats->total_calls++;
     if (ns != kDefaultNamespace) {
        stats->ns_command_calls[ns]++;
     }
   }
   ```
   
   so that we don't need to intercepting the stats and namespace in serval 
places. cc @jihuayu @PragmaTwice 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to