maoyouaa opened a new pull request, #3563: URL: https://github.com/apache/kvrocks/pull/3563
## What changed - install the Go 1.25 toolchain from the official `golang` image - use Ubuntu Noble's default `clang-format` and `clang-tidy` packages, which provide LLVM 18 - retry APT package installation in the same image layer to tolerate transient mirror failures ## Why The development container still installed Ubuntu's Go 1.22 package and explicitly selected Clang 14. The current Go test module requires Go 1.25, while `x.py` requires Clang 18 for format and tidy checks. As a result, a freshly built development container could not run the current project checks with its packaged toolchain. ## Impact New development containers provide the tool versions expected by the repository without replacing the existing Ubuntu Noble base image or changing the runtime build. ## Validation - `./x.py build --unittest --ninja --compiler=clang -j 12` - `./x.py test cpp build` (600 passed, 1 skipped) - `./x.py test go build -run TestPing` - `./x.py check golangci-lint` (0 issues) - full Docker image build and cached rebuild - container smoke check: Go 1.25.12, clang-format 18.1.3, clang-tidy 18.1.3, and minica - `git diff --check` `./x.py check format --clang-format-path clang-format-18` also reports existing formatting violations in untouched `src/cli/main.cc` and `tests/cppunit/config_test.cc` lines. Prepared with assistance from OpenAI Codex and verified locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
