maoyouaa commented on code in PR #3563: URL: https://github.com/apache/kvrocks/pull/3563#discussion_r3619516313
########## .devcontainer/Dockerfile: ########## @@ -1,9 +1,20 @@ +FROM golang:1.25-bookworm AS go-toolchain + FROM ubuntu:noble Review Comment: Thanks. I simplified the devcontainer to use `ubuntu:resolute` and its packaged Go toolchain. I also pinned the default format/tidy commands to LLVM 18 to match CI. A clean Kvrocks build on Resolute exposed the same `libatomic` link requirement already handled in the production Dockerfile, so the container now sets `LDFLAGS=-latomic`. The image build, full Clang build, C++ tests, `TestPing`, format check, and clang-tidy all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
