maoyouaa commented on code in PR #3563:
URL: https://github.com/apache/kvrocks/pull/3563#discussion_r3621941203
##########
.devcontainer/Dockerfile:
##########
@@ -1,9 +1,14 @@
-FROM ubuntu:noble
+FROM ubuntu:resolute
RUN apt update \
&& apt install -y \
git build-essential cmake libtool python3 libssl-dev python3-pip \
- wget curl clang-format-14 clang-tidy-14 golang-go ninja-build \
+ wget curl clang-format-18 clang-tidy-18 golang-go ninja-build \
redis-tools vim python3-redis redis-server clang lld mold gdb fish
+RUN ln -s /usr/bin/clang-format-18 /usr/local/bin/clang-format \
+ && ln -s /usr/bin/clang-tidy-18 /usr/local/bin/clang-tidy \
+ && ln -s /usr/bin/run-clang-tidy-18 /usr/local/bin/run-clang-tidy
RUN BUILD_DIR=$(pwd) && git clone https://github.com/jsha/minica /opt/minica \
&& cd /opt/minica && git checkout 96a5c93723cf3d34b50b3e723a9f05cd3765bc67
&& go build && cd $BUILD_DIR \
&& echo 'export PATH=/opt/minica:$PATH' >> $HOME/.bashrc
+
+ENV LDFLAGS="-latomic"
Review Comment:
You're right — it isn't needed for the default GCC build. It was added after
testing an explicit Clang build, so I've removed the global `LDFLAGS`. A clean
GCC 15 build and the tests pass without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
