[
https://issues.apache.org/jira/browse/KYLIN-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701470#comment-16701470
]
ASF GitHub Bot commented on KYLIN-2578:
---------------------------------------
Aaaaaaron commented on a change in pull request #365: KYLIN-2578, clean
deprecated config("kylin.job.lock") usage in the code.
URL: https://github.com/apache/kylin/pull/365#discussion_r236961076
##########
File path:
kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
##########
@@ -69,7 +69,6 @@
@BeforeClass
public static void setup() throws Exception {
staticCreateTestMetadata();
- System.setProperty("kylin.job.lock",
"org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock");
Review comment:
In fact, class "ZookeeperDistributedJobLock" already has been renamed to
"ZookeeperDistributedLock"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor DistributedLock
> ------------------------
>
> Key: KYLIN-2578
> URL: https://issues.apache.org/jira/browse/KYLIN-2578
> Project: Kylin
> Issue Type: Improvement
> Reporter: liyang
> Assignee: liyang
> Priority: Major
> Fix For: v2.1.0
>
>
> The current {{DistributedLock}} could use some improvement:
> - A {{lockClient}} is unnecessarily required.
> - The {{watchPath}} is actually an on-unlock listener and the current name
> failed to make it clear.
> - Could add a blocking version of {{lockPath}} and that will ease use cases
> like KYLIN-2557 and {{GlobalDictionaryBuilder.lock()}}
> - Should add more javadoc on the interface
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
