[
https://issues.apache.org/jira/browse/KYLIN-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701484#comment-16701484
]
ASF GitHub Bot commented on KYLIN-2578:
---------------------------------------
coveralls commented on issue #365: KYLIN-2578, clean deprecated
config("kylin.job.lock") usage in the code.
URL: https://github.com/apache/kylin/pull/365#issuecomment-442347902
## Pull Request Test Coverage Report for [Build
3898](https://coveralls.io/builds/20330244)
* **0** of **0** changed or added relevant lines in **0** files are
covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.001%**) to **25.949%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20330244/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
| 1 | 81.08% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/20330244)
|
| :-- | --: |
| Change from base [Build 3894](https://coveralls.io/builds/20327415): |
0.001% |
| Covered Lines: | 17651 |
| Relevant Lines: | 68023 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor DistributedLock
> ------------------------
>
> Key: KYLIN-2578
> URL: https://issues.apache.org/jira/browse/KYLIN-2578
> Project: Kylin
> Issue Type: Improvement
> Reporter: liyang
> Assignee: liyang
> Priority: Major
> Fix For: v2.1.0
>
>
> The current {{DistributedLock}} could use some improvement:
> - A {{lockClient}} is unnecessarily required.
> - The {{watchPath}} is actually an on-unlock listener and the current name
> failed to make it clear.
> - Could add a blocking version of {{lockPath}} and that will ease use cases
> like KYLIN-2557 and {{GlobalDictionaryBuilder.lock()}}
> - Should add more javadoc on the interface
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
