[
https://issues.apache.org/jira/browse/KYLIN-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701483#comment-16701483
]
ASF GitHub Bot commented on KYLIN-2578:
---------------------------------------
codecov-io commented on issue #365: KYLIN-2578, clean deprecated
config("kylin.job.lock") usage in the code.
URL: https://github.com/apache/kylin/pull/365#issuecomment-442347708
# [Codecov](https://codecov.io/gh/apache/kylin/pull/365?src=pr&el=h1) Report
> Merging [#365](https://codecov.io/gh/apache/kylin/pull/365?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/97ee98bfbd93510b578db93998f2ab488199ef40?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/365?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #365 +/- ##
============================================
+ Coverage 23.63% 23.63% +<.01%
+ Complexity 4828 4827 -1
============================================
Files 1130 1130
Lines 68023 68023
Branches 9657 9657
============================================
+ Hits 16079 16080 +1
+ Misses 50377 50376 -1
Partials 1567 1567
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/365?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...ylin/job/impl/threadpool/DistributedScheduler.java](https://codecov.io/gh/apache/kylin/pull/365/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGlzdHJpYnV0ZWRTY2hlZHVsZXIuamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/365/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
|
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/365/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
|
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/365/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: |
|
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/365/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
| `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/365?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/365?src=pr&el=footer). Last
update
[97ee98b...09117c0](https://codecov.io/gh/apache/kylin/pull/365?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor DistributedLock
> ------------------------
>
> Key: KYLIN-2578
> URL: https://issues.apache.org/jira/browse/KYLIN-2578
> Project: Kylin
> Issue Type: Improvement
> Reporter: liyang
> Assignee: liyang
> Priority: Major
> Fix For: v2.1.0
>
>
> The current {{DistributedLock}} could use some improvement:
> - A {{lockClient}} is unnecessarily required.
> - The {{watchPath}} is actually an on-unlock listener and the current name
> failed to make it clear.
> - Could add a blocking version of {{lockPath}} and that will ease use cases
> like KYLIN-2557 and {{GlobalDictionaryBuilder.lock()}}
> - Should add more javadoc on the interface
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
