[
https://issues.apache.org/jira/browse/KYLIN-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243854#comment-17243854
]
ASF GitHub Bot commented on KYLIN-4817:
---------------------------------------
hit-lacus commented on a change in pull request #1496:
URL: https://github.com/apache/kylin/pull/1496#discussion_r535931203
##########
File path:
kylin-spark-project/kylin-spark-common/src/main/java/org/apache/kylin/engine/spark/metadata/cube/PathManager.java
##########
@@ -49,6 +49,12 @@ public static String
getSegmentParquetStoragePath(CubeInstance cube, String segN
return hdfsWorkDir + "parquet" + File.separator + cube.getName() +
File.separator + segName + "_" + identifier;
}
+ public static String getSegmentParquetStoragePath(String hdfsWorkDir,
String cubeName, CubeSegment segment) {
+ String segmentName = segment.getName();
+ String identifier = segment.getStorageLocationIdentifier();
+ return hdfsWorkDir + "parquet" + File.separator + cubeName +
File.separator + segmentName + "_" + identifier;
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refine Cube Migration Tool for Kylin4
> -------------------------------------
>
> Key: KYLIN-4817
> URL: https://issues.apache.org/jira/browse/KYLIN-4817
> Project: Kylin
> Issue Type: Improvement
> Components: Client - CLI
> Reporter: Xiaoxiang Yu
> Assignee: Yaqian Zhang
> Priority: Major
> Fix For: v4.0.0-beta
>
>
> - Collect and analyse all cube migration tool used in current Kylin.
> - Verify if them works in Kylin4, if not, make them works.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
