[
https://issues.apache.org/jira/browse/KYLIN-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243934#comment-17243934
]
ASF GitHub Bot commented on KYLIN-4817:
---------------------------------------
hit-lacus commented on a change in pull request #1496:
URL: https://github.com/apache/kylin/pull/1496#discussion_r536012522
##########
File path: tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java
##########
@@ -326,22 +292,32 @@ protected void listCubeRelatedResources(CubeInstance
cube, List<String> metaReso
metaResource.addAll(getCompatibleTablePath(tblRefs, prj,
ResourceStore.TABLE_EXD_RESOURCE_ROOT));
if (doMigrateSegment) {
+ for (DictionaryDesc dictionaryDesc : cubeDesc.getDictionaries()) {
+ String[] columnInfo =
dictionaryDesc.getColumnRef().getColumnWithTable().split("\\.");
+ String globalDictPath;
+ if (columnInfo.length == 3) {
Review comment:
In which case `columnInfo.length` is not 3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refine Cube Migration Tool for Kylin4
> -------------------------------------
>
> Key: KYLIN-4817
> URL: https://issues.apache.org/jira/browse/KYLIN-4817
> Project: Kylin
> Issue Type: Improvement
> Components: Client - CLI
> Reporter: Xiaoxiang Yu
> Assignee: Yaqian Zhang
> Priority: Major
> Fix For: v4.0.0-beta
>
>
> - Collect and analyse all cube migration tool used in current Kylin.
> - Verify if them works in Kylin4, if not, make them works.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
