[
https://issues.apache.org/jira/browse/KYLIN-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243929#comment-17243929
]
ASF GitHub Bot commented on KYLIN-4817:
---------------------------------------
hit-lacus commented on a change in pull request #1496:
URL: https://github.com/apache/kylin/pull/1496#discussion_r536007735
##########
File path: tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java
##########
@@ -192,20 +184,12 @@ public void moveCube(KylinConfig srcCfg, KylinConfig
dstCfg, String cubeName, St
if (realExecute) {
doOpts();
- if (migrateSegment) {
- checkMigrationSuccess(dstConfig, cubeName, true);
- }
updateMeta(dstConfig, projectName, cubeName, cube.getModel());
} else {
showOpts();
}
}
- public void checkMigrationSuccess(KylinConfig kylinConfig, String
cubeName, Boolean ifFix) throws IOException {
- CubeMigrationCheckCLI checkCLI = new
CubeMigrationCheckCLI(kylinConfig, ifFix);
Review comment:
After remove HBase, looks like we do not need `CubeMigrationCheckCLI`
any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refine Cube Migration Tool for Kylin4
> -------------------------------------
>
> Key: KYLIN-4817
> URL: https://issues.apache.org/jira/browse/KYLIN-4817
> Project: Kylin
> Issue Type: Improvement
> Components: Client - CLI
> Reporter: Xiaoxiang Yu
> Assignee: Yaqian Zhang
> Priority: Major
> Fix For: v4.0.0-beta
>
>
> - Collect and analyse all cube migration tool used in current Kylin.
> - Verify if them works in Kylin4, if not, make them works.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
