jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous
Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/916#discussion_r332853732
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -732,8 +734,25 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) throws IOExcepti
if (docIdSet == null) {
if (policy.shouldCache(in.getQuery())) {
- docIdSet = cache(context);
- putIfAbsent(in.getQuery(), docIdSet, cacheHelper);
+ boolean cacheSynchronously = executor == null;
+ boolean asyncCachingSucceeded = false;
+
+ // If asynchronous caching is requested, perform the same and return
+ // the uncached iterator
+ if (cacheSynchronously == false) {
+ asyncCachingSucceeded = cacheAsynchronously(context, cacheHelper);
+
+ // If async caching failed, synchronous caching will
+ // be performed, hence do not return the uncached value
+ if (asyncCachingSucceeded) {
+ return in.scorerSupplier(context);
+ }
+ }
+
+ if (cacheSynchronously || asyncCachingSucceeded == false) {
Review comment:
`asyncCachingSucceeded` can only be `false` here, or do I miss something? If
this is correct, then we could declare `asyncCachingSucceeded` under the `if`
statement to reduce its scope?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
