jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous
Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/916#discussion_r331589988
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -832,5 +866,23 @@ public BulkScorer bulkScorer(LeafReaderContext context)
throws IOException {
return new DefaultBulkScorer(new ConstantScoreScorer(this, 0f,
ScoreMode.COMPLETE_NO_SCORES, disi));
}
+ // Perform a cache load asynchronously
+ // @return true if asynchronous caching succeeded, false otherwise
+ private boolean cacheAsynchronously(LeafReaderContext context,
IndexReader.CacheHelper cacheHelper) {
+ FutureTask<Void> task = new FutureTask<>(() -> {
+ DocIdSet localDocIdSet = cache(context);
Review comment:
Since we are caching asynchronously, we might me hitting a closed segment.
We should use `LeafReader#tryIncRef` to make sure the reader is still open and
add tests for that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
