jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous
Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/916#discussion_r331385596
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -450,11 +453,15 @@ void assertConsistent() {
@Override
public Weight doCache(Weight weight, QueryCachingPolicy policy) {
- while (weight instanceof CachingWrapperWeight) {
- weight = ((CachingWrapperWeight) weight).in;
- }
+ return doCache(weight, policy, null /* executor */);
+ }
- return new CachingWrapperWeight(weight, policy);
+ // Should be used only when the user wishes to trade throughput for latency
+ // This method was not merged in the method above as to not break the
existing contract
+ // advertised by QueryCache
Review comment:
I think breaking is fine since QueryCache is `@lucene.experimental`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
