sigram commented on a change in pull request #959: SOLR-13677 fix & cleanup
URL: https://github.com/apache/lucene-solr/pull/959#discussion_r335864880
##########
File path:
solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java
##########
@@ -325,8 +335,123 @@ public void testKeyMetrics() throws Exception {
handler.handleRequestBody(req(CommonParams.QT, "/admin/metrics",
CommonParams.WT, "json",
MetricsHandler.KEY_PARAM, "solr.jetty:unknown:baz"), resp);
values = resp.getValues();
- metrics = (NamedList)values.get("metrics");
+ metrics = (NamedList) values.get("metrics");
assertEquals(0, metrics.size());
assertNotNull(values.findRecursive("errors", "solr.jetty:unknown:baz"));
}
+
+ @Test
+ public void testMetricsUnload() throws Exception {
Review comment:
We need another test that tests the following scenario:
* instance 1 registers its gauges
* instance 2 is created and registers its gauges
* instance 1 is closed and should unregister its gauges
together with dependent child instances
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
