sigram commented on a change in pull request #959: SOLR-13677 fix & cleanup
URL: https://github.com/apache/lucene-solr/pull/959#discussion_r335843096
##########
File path: solr/core/src/java/org/apache/solr/core/HdfsDirectoryFactory.java
##########
@@ -141,6 +142,13 @@ public void close() throws IOException {
}
tmpFsCache.invalidateAll();
tmpFsCache.cleanUp();
+ try {
+ SolrMetricProducer.super.close();
+ MetricsHolder.metrics.close();
+ LocalityHolder.reporter.close();
Review comment:
These two classes feel like a giant hack. Why can't we use non-static
objects here, instead of keeping around these static holders? But that's
another battle. Here it still needs to be closed to release possible references
in MetricsMap to HdfsDirectory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
