sigram commented on a change in pull request #959: SOLR-13677 fix & cleanup
URL: https://github.com/apache/lucene-solr/pull/959#discussion_r335843567
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -687,6 +689,7 @@ public SolrCore reload(ConfigSet coreConfig) throws
IOException {
}
private DirectoryFactory initDirectoryFactory() {
+ // XXX some factory implementations are also SolrMetricProducer-s
Review comment:
I'll remove this - got confused. Metrics are initialized elsewhere for this
component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
