sigram commented on a change in pull request #959: SOLR-13677 fix & cleanup
URL: https://github.com/apache/lucene-solr/pull/959#discussion_r335841179
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -638,7 +643,7 @@ public void load() {
if (isZooKeeperAware()) {
pkiAuthenticationPlugin = new PKIAuthenticationPlugin(this,
zkSys.getZkController().getNodeName(),
(PublicKeyHandler) containerHandlers.get(PublicKeyHandler.PATH));
- pkiAuthenticationPlugin.initializeMetrics(metricManager,
SolrInfoBean.Group.node.toString(), metricTag, "/authentication/pki");
+ pkiAuthenticationPlugin.initializeMetrics(solrMetricsContext,
"/authentication/pki");
Review comment:
Probably need to revert it to the old API to preserve back-compat on
branch_8x, because it's a pluggable component where third-party implementations
may exist. For non-pluggable components in many places I switched over to the
new API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
