shbhar commented on PR #16923: URL: https://github.com/apache/lucene/pull/16923#issuecomment-6677114071
Other than the flaky test verification and fix, the code looks good to me. You would also need to add CHANGES.txt for all the bug fixes (I think you have fixed 3 together?). I liked the way you put expected contractual behavior in comment block above `TestIndexVersionInvariants` - I wonder if we should put it in some other places as well like related javadocs maybe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
