[ 
https://issues.apache.org/jira/browse/SOLR-13992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014276#comment-17014276
 ] 

Jan Høydahl commented on SOLR-13992:
------------------------------------

[~noble.paul]

This issue changes the only constructor of Slice. I had some plugin relying on 
the (public) Slice class which now breaks. Would be nice if when changing APIs 
in minor releases, if you provide a **deprecated** overloaded constructor with 
the old signature and in this case e.g. initialize {{collection="(not 
provided)"}} or similar.

Also, the new constructor does not add javadoc for the new 'collection' 
parameter - please fix.

> Refactor code to have collection name shard name in Replica,Slice
> -----------------------------------------------------------------
>
>                 Key: SOLR-13992
>                 URL: https://issues.apache.org/jira/browse/SOLR-13992
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>             Fix For: 8.4
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> * Replica should have the collection-name and shard name
> * Slice should have the collection-name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to