dsmiley commented on a change in pull request #1303: LUCENE-9114: Improve
ValueSourceScorer's Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#discussion_r387438763
##########
File path:
lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java
##########
@@ -94,4 +104,12 @@ public float getMaxScore(int upTo) throws IOException {
return Float.POSITIVE_INFINITY;
}
+ /**
+ * Used to externally set a mutable cost for this instance. If set, this
cost gets preference over the FunctionValues's cost
+ *
+ * @lucene.experimental
+ */
+ public void setExternallyMutableCost(float cost) {
Review comment:
Why not simply setMatchCost ? It's apparent it's "mutable", and it's public
and thus "externally" so :-)
I think the javadocs should reference TPI.matchCost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
