dsmiley commented on a change in pull request #1303: LUCENE-9114: Improve
ValueSourceScorer's Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#discussion_r387663374
##########
File path:
lucene/queries/src/java/org/apache/lucene/queries/function/FunctionValues.java
##########
@@ -151,6 +164,11 @@ public ValueSourceScorer getScorer(Weight weight,
LeafReaderContext readerContex
public boolean matches(int doc) {
return true;
}
+ @Override
+ public float costEvaluationFunction() {
+ // Match everything
Review comment:
Nitpick comment: the point isn't that we're matching everything, the point
is that matches() merely returns a constant and is thus virtually free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
