jpountz commented on pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#issuecomment-619245099
> Any number > Integer.MAX_VALUE means that each shard will reply with accurate count, right? so the sum of them all will also be accurate. Yes indeed. The perspective I had was rather than since this parameter is a number of hits, as a user I would expect any legal number of hits to also be a legal value for this parameter. So it would be a shame to fail or worse silently cast to an int if a user passes 3B as a value? I believe it would be fine to keep it an integer internally but carefully accepting longs when parsing URL parameters and rounding to the nearest integer, ie. all value greater than Integer.MAX_VALUE would get converted to Integer.MAX_VALUE? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
