dsmiley commented on pull request #1600: URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648157149
> Why clutter up CoreContainer with path logic when we have classes specifically meant to hold that? `CoreContainer.getSolrHome()` and `CoreContainer.getCoreRootDirectory` are two other node level paths attached to CC, so why not this one as well? I could easily forsee an improvement to "userfiles" where it's location is configurable just as the previous two are. My only concern, which seems to be shared by you, is that CoreContainer is pretty big as it is. But I think this path and it's initialization is in scope of its responsibility. I could forsee reducing the length of CC in other ways. > but I also had no idea that there was anything wrong with using File Lucene fully converted in https://issues.apache.org/jira/browse/LUCENE-5945 (see opening description). See official information from Oracle https://docs.oracle.com/javase/tutorial/essential/io/legacy.html The main thing "wrong" with the code I couldn't stand was the excessive and needless use of Strings for fields/parameters/variables that were paths. Imagine if you looked at someone's calculator app only to see the numeric value held as a String always! Here, *if* I saw File used pervasively, I wouldn't of bothered doing the conversion to Path because at least File is a respectable choice but not String. Hey @ErickErickson if you are up for more cleanup tasks, maybe you might be interested in a full conversion of File -> Path cutover. At least for anything non-private and 9.0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
