gerlowskija commented on pull request #1600: URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648235882
> My only concern, which seems to be shared by you, is that CoreContainer is pretty big as it is. But I think this path and it's initialization is in scope of its responsibility. I could forsee reducing the length of CC in other ways Yeah, that was my concern for sure. I don't think `getSolrHome()` and `getCoreRootDirectory` are terribly placed in CoreContainer - but I think there's a good SRP argument to make that they'd be better belong in somewhere more specifically targeted to that functionality like `SolrPaths`. But I hear your point that there's already precedent for this functionality in CoreContainer, and that ultimately none of this is going to do much to slim down CoreContainer. So LGTM. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
