MarcusSorealheis commented on a change in pull request #1755:
URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r471908464



##########
File path: 
solr/solrj/src/java/org/apache/solr/common/annotation/SolrThreadUnsafe.java
##########
@@ -29,6 +29,6 @@
 @Documented
 @Retention(SOURCE)
 @Target(TYPE)
-public @interface SolrSingleThreaded {

Review comment:
       I think it's a good thought. The reason I think it is so prescient is 
the fact that this annotation originated in a private branch where I expect 
many pieces will land in open source. The original annotation name may be used 
in that code. Keeping this name for now will make it easier to bring that work 
into open source.
   
   If it's in their custom code, I would hope the name change would be trivial.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to