anshumg commented on a change in pull request #1755:
URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r473282984
##########
File path:
solr/solrj/src/java/org/apache/solr/common/annotation/SolrThreadUnsafe.java
##########
@@ -29,6 +29,6 @@
@Documented
@Retention(SOURCE)
@Target(TYPE)
-public @interface SolrSingleThreaded {
Review comment:
I thought I left a comment here but seems like I missed it.
I agree that it will make it easier for people to use the wrong annotation,
but that's something that the person who writes/reviews/commits should notice.
It's also something we could change, but removing this annotation is going to
lead to a breaking change which we might have to just live with for back-compat
reasons.
The private branch is no longer really in use, so we don't have to worry
about anything from that specific branch making it into upstream.
Let's leave the old annotation as deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
