[ https://issues.apache.org/jira/browse/SOLR-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198933#comment-17198933 ]
Uwe Schindler commented on SOLR-14824: -------------------------------------- Hi Hoss, I just fixed a string escaping bug that affected all windows builds: {noformat} diff --git a/solr/solr-ref-guide/build.gradle b/solr/solr-ref-guide/build.gradle index f6320e8d79d..0a4bf84a22c 100644 --- a/solr/solr-ref-guide/build.gradle +++ b/solr/solr-ref-guide/build.gradle @@ -35,6 +35,7 @@ import java.time.* import java.time.format.* import java.nio.file.* import org.asciidoctor.* +import groovy.json.StringEscapeUtils buildscript { repositories { @@ -151,7 +152,7 @@ ext { javadocLink: "https://docs.oracle.com/en/java/javase/11/docs/api/", solrGuideDraftStatus: propertyOrDefault("solrGuideDraft", "true").toBoolean() ? "DRAFT" : "", - solrRootPath: project(':solr').projectDir.toString() + File.separator, + solrRootPath: StringEscapeUtils.escapeJava(project(':solr').projectDir.toString() + File.separator), solrDocsVersion: solrDocsVersion, solrGuideVersionPath: solrGuideVersionPath, {noformat} Problem was that backslashes are used to escape strings, but windows paths also have those. Fix was to add StringEscapeUtils, but I don't like this too much. Maybe we find a better solution to make special characters in those properties escaped correctly when used in strings inside templates. > Simplify set of Ref Guide build parameters > ------------------------------------------ > > Key: SOLR-14824 > URL: https://issues.apache.org/jira/browse/SOLR-14824 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Build, documentation > Reporter: Cassandra Targett > Assignee: Chris M. Hostetter > Priority: Minor > Fix For: master (9.0) > > Attachments: SOLR-14824.patch, SOLR-14824.patch, SOLR-14824.patch > > > While trying to solve LUCENE-9495, I thought it might be a good idea to try > to simplify the set of variables and properties used during the Ref Guide > build. > There are 3 areas to work on: > 1. Remove the "barebones-html" build. With Gradle the build is self-contained > and {{gradlew check}} and {{gradle precommit}} could just build the full docs > and check them. > 2. Remove some properties that only existed for a hypothetical need related > to the now-removed PDF. > 3. Change remaining properties to be defined directly in build.gradle instead > of relying on ant properties functionality. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org