gus-asf commented on a change in pull request #1965:
URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504996141
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java
##########
@@ -125,7 +125,7 @@ public void reflectWith(AttributeReflector reflector) {
// arriving to pos Y have the same endOffset)
public static void assertTokenStreamContents(TokenStream ts, String[]
output, int startOffsets[], int endOffsets[], String types[], int
posIncrements[],
Review comment:
Done, I think what was originally submitted was a bit easier than
sorting out all the parameters at the time, but yes nicer to minimize.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
