uschindler commented on a change in pull request #1965:
URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504855884
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/TypeAsSynonymFilter.java
##########
@@ -64,9 +82,15 @@ public boolean incrementToken() throws IOException {
}
termAtt.append(typeAtt.type());
posIncrAtt.setPositionIncrement(0);
+ // control what flags transfer to synonym
+ int flags = getAttribute(FlagsAttribute.class).getFlags();
Review comment:
This should not call getAttribute and instead use the instance
`flagsAtt` above (instance field). In the next line it's correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
