uschindler commented on a change in pull request #1965:
URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504863498
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java
##########
@@ -190,7 +196,8 @@ public static void assertTokenStreamContents(TokenStream
ts, String[] output, in
if (posLengthAtt != null) posLengthAtt.setPositionLength(45987653);
if (keywordAtt != null) keywordAtt.setKeyword((i&1) == 0);
if (payloadAtt != null) payloadAtt.setPayload(new BytesRef(new byte[] {
0x00, -0x21, 0x12, -0x43, 0x24 }));
-
+ if (flagsAtt != null) flagsAtt.setFlags(Integer.MAX_VALUE); // all 1's
Review comment:
that's all bits except the first 1 (`01111111111111111...`). To invert
all bits use `-1` or better `~0`
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java
##########
@@ -125,7 +125,7 @@ public void reflectWith(AttributeReflector reflector) {
// arriving to pos Y have the same endOffset)
public static void assertTokenStreamContents(TokenStream ts, String[]
output, int startOffsets[], int endOffsets[], String types[], int
posIncrements[],
Review comment:
maybe we should not change this method signature and just add another
one, so we do not need to change unrelated files like MinHashFilter?
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java
##########
@@ -294,6 +304,7 @@ public static void assertTokenStreamContents(TokenStream
ts, String[] output, in
if (posLengthAtt != null) posLengthAtt.setPositionLength(45987653);
if (keywordAtt != null) keywordAtt.setKeyword(true);
if (payloadAtt != null) payloadAtt.setPayload(new BytesRef(new byte[] {
0x00, -0x21, 0x12, -0x43, 0x24 }));
+ if (flagsAtt != null) flagsAtt.setFlags(Integer.MAX_VALUE); // all 1's
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
