epugh commented on a change in pull request #2215:
URL: https://github.com/apache/lucene-solr/pull/2215#discussion_r559674364
##########
File path: solr/CHANGES.txt
##########
@@ -186,6 +186,9 @@ Other Changes
* SOLR-14034: Remove deprecated min_rf references (Tim Dillon)
+* SOLR-14067: StatelessScriptUpdateProcessor moved to it's own
/contrib/scripting/ package instead
+ of shipping as part of Solr due to security concerns. Renamed to
ScriptingUpdateProcessor. (Eric Pugh)
Review comment:
I don't love that we have the `Factory` suffix, as that feels like an
implementation detail of how update processors work.
I wish we could refer to this as the `ScriptUpdateProcessor`, even though
this specific class is buried in the file `ScriptUpdateProcessorFactory.java`
as:
```
private static class ScriptUpdateProcessor extends UpdateRequestProcessor
```
Would it be worth pulling the inner class to it's own
`ScriptUpdateProcessor.java` file?
Then we could just link to that file everywhere. Thoughts????
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
