dsmiley commented on a change in pull request #2215:
URL: https://github.com/apache/lucene-solr/pull/2215#discussion_r559735328
##########
File path: solr/solr-ref-guide/src/script-update-processor.adoc
##########
@@ -35,19 +35,19 @@ potential security vulnerabilities.
The scripting update processor lives in the contrib module
`/contrib/scripting`, and you need to explicitly add it to your Solr setup.
-Java 11 and previous versions come with a JavaScript engine called Nashorn,
but Java 12 will require you to add your own JavaScript engine. Other
supported scripting engines like
-JRuby, Jython, Groovy, all require you to add JAR files.
-
-
-You can either add the `dist/solr-scripting-*.jar` file into Solr’s resource
loader in a core `lib/` directory, or via `<lib>` directives in
`solrconfig.xml`:
+You can either add the `dist/solr-scripting-*.jar` file into Solr’s core
`lib/` directory, or via `<lib>` directives in `solrconfig.xml`:
Review comment:
It's more probable someone would use SOLR_HOME/lib than a lib directory
on a core. And FYI `<lib>` directives may be going away or be discouraged.
Let's link to `<<libs.adoc#lib-directories,Lib Directories>>` instead of
enumerating how to do this, so we can just maintain this sort of info in one
place in the ref guide.
##########
File path: solr/solr-ref-guide/src/script-update-processor.adoc
##########
@@ -267,8 +267,8 @@ def finish() {
}
----
-=== Jython
-
+=== Python
+Python support is implemented via the https://www.jython.org/[Jython] project.
Put the *standalone* `jython.jar` (the JAR that contains all the dependencies)
into Solr's resource loader.
Review comment:
Please remove "resource loader" from this page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
