murblanc commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r559755408
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteReplicaCmd.java
##########
@@ -147,14 +170,27 @@ void deleteReplicaBasedOnCount(ClusterState clusterState,
}
}
+ if (placementPlugin != null) {
Review comment:
In `Assign.AssignStrategy` if we want to be exhaustive, we should for
example reject shard splits for secondary that are targets of `withCollection`
(given we refuse such targets to have more than one shard).
Not saying we should do it, but the vetting infra we put in place should
allow logical extension to all these aspects (with minor impact on the
commands).
Also, pushing all the logic to `Assign.AssignStrategy` and minimizing
changes to `*Cmd` limits the impact of a regression (moving to
`LegacyAssignStrategy` should be a workaround for most problems).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
