murblanc commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r559766377
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##########
@@ -171,14 +174,17 @@ public AffinityPlacementConfig getConfig() {
private final long prioritizedFreeDiskGB;
+ private final Map<String, String> withCollections;
Review comment:
Q: a given collection can only be `withCollection` for a single
secondary collection? Doesn't seem to be a necessary limitation...
Suggestion: maintain the inverse mapping as well (a multimap, but possibly
this one should be a multimap as well) to save looping through map keys
checking values...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
