thelabdude commented on a change in pull request #151:
URL: 
https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568127921



##########
File path: main.go
##########
@@ -65,6 +69,7 @@ func init() {
 
        _ = solrv1beta1.AddToScheme(scheme)
        _ = zkv1beta1.AddToScheme(scheme)
+       _ = certv1.AddToScheme(scheme)
 
        // +kubebuilder:scaffold:scheme
        flag.BoolVar(&useZookeeperCRD, "zk-operator", true, "The operator will 
not use the zk operator & crd when this flag is set to false.")

Review comment:
       As far as I've seen, calling `AddToScheme` works even if the 
Cert-manager CRDs are not installed so not sure a flag is technically needed 
but doesn't hurt to add one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to