thelabdude commented on a change in pull request #151:
URL:
https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568141856
##########
File path: main.go
##########
@@ -65,6 +69,7 @@ func init() {
_ = solrv1beta1.AddToScheme(scheme)
_ = zkv1beta1.AddToScheme(scheme)
+ _ = certv1.AddToScheme(scheme)
// +kubebuilder:scaffold:scheme
flag.BoolVar(&useZookeeperCRD, "zk-operator", true, "The operator will
not use the zk operator & crd when this flag is set to false.")
Review comment:
Ok I see, I was confused because you put the comment on the
`AddToScheme` line so thought the problem was about that line of code.
I don't think the Solr operator needs to own `Certificate` objects ... all
it cares about is the TLS secret that gets created by the cert-manager in
response to a change to the `Certificate`. It seems like the secret changing
does trigger a reconcile in my testing but maybe we need to add a specific
watch for that secret changing like you did for user-provided ConfigMaps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
