thelabdude commented on a change in pull request #151:
URL:
https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568152014
##########
File path: main.go
##########
@@ -65,6 +69,7 @@ func init() {
_ = solrv1beta1.AddToScheme(scheme)
_ = zkv1beta1.AddToScheme(scheme)
+ _ = certv1.AddToScheme(scheme)
// +kubebuilder:scaffold:scheme
flag.BoolVar(&useZookeeperCRD, "zk-operator", true, "The operator will
not use the zk operator & crd when this flag is set to false.")
Review comment:
From a reconcile perspective, we really only care about the TLS secret
that cert-manager creates once the Certificate is issued. The "watching" of the
Certificate to come online is really for status reporting while the cert is
issuing as it can take several minutes for the cert to be issued. Notice the
`isCertificateReady` is mostly about checking for the TLS secret.
The operator does create a Certificate for `autoCreate` mode but in that
case, the cert definition should come from the SolrCloud CRD and we don't want
to let users edit the Certificate externally; this is similar to the default
`solr.xml` ConfigMap and any direct edits to that cm are lost, same with
`autoCreate` certs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
