dweiss commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625549585
##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, validateJarLicenses
+ licenses.dependsOn validateJarLicenses
}
// Add top-project level tasks validating dangling files
// and regenerating dependency checksums.
configure(project(":lucene")) {
def validationTasks = subprojects.collectMany { it.tasks.matching { it.name
== "licenses" } }
- def jarInfoTasks = subprojects.collectMany { it.tasks.matching { it.name ==
"collectJarInfos" } }
-
- // Update dependency checksums.
- task updateLicenses() {
Review comment:
Check is just a convention aggregation task, nothing else. We have
*tons* of other stuff that isn't connected with check in the execution graph -
I bet some of these dependencies/ configurations are in in plugins and it'd be
difficult to even hook into them to disable automatic dependency verification.
The work on this attempt isn't lost though (thank you!). Let's keep an eye
on what happens with gradle's built-in checkums and retry the attempt when it's
more flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
