gsmiller commented on a change in pull request #233: URL: https://github.com/apache/lucene/pull/233#discussion_r689109727
########## File path: lucene/core/src/java/org/apache/lucene/search/Values.java ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.search; + +import java.io.IOException; + +/** + * Per-segment, per-document values, which can be calculated at search-time See also: {@link + * LongValues}, {@link DoubleValues} + */ +public abstract class Values { Review comment: While thinking about this more though, I _did_ rename it to reflect the more general concept of something that can be positioned on a specified doc but cannot necessarily provide iteration itself. I like this idea in general (and the idea of being able to wrap a "leader" and list of "followers" with a DISI), but I'd be curious if others are opposed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
