jpountz commented on pull request #233: URL: https://github.com/apache/lucene/pull/233#issuecomment-900054281
While having abstraction for conjunction of DocIdSetIterators makes sense to me because it encapsulates important logic such as sorting iterators by increasing cost, I'm not convinced of the value of this pull request. It saves one line of code here or there, but at the cost of the additional `DocIdPositionable` API, which we said we wanted to avoid in previous discussions, see e.g. [LUCENE-9081](https://issues.apache.org/jira/browse/LUCENE-9081). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
