[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399740#comment-17399740
]
Michael Sokolov commented on LUCENE-8638:
-----------------------------------------
I opened a PR with the easy changes from the master-deprecations branch. Still
TODO are deprecations in:
```
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/FixBrokenOffsetsFilterFactory.java:@Deprecated
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/FixBrokenOffsetsFilter.java:@Deprecated
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/WordDelimiterFilterFactory.java:@Deprecated
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/WordDelimiterFilter.java:@Deprecated
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java:@Deprecated
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilter.java:@Deprecated
lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestFixBrokenOffsetsFilter.java:@Deprecated
lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestWordDelimiterFilter.java:@Deprecated
lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSolrSynonymParser.java:@Deprecated
lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymFilterFactory.java:@Deprecated
lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymMapFilter.java:@Deprecated
lucene/core/src/java/org/apache/lucene/index/IndexReader.java: @Deprecated
lucene/core/src/java/org/apache/lucene/store/DataInput.java: @Deprecated
lucene/core/src/java/org/apache/lucene/util/CharsRef.java: @Deprecated
lucene/core/src/java/org/apache/lucene/util/ClasspathResourceLoader.java:
@Deprecated
lucene/core/src/java/org/apache/lucene/util/fst/Util.java: @Deprecated
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
@Deprecated
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptLexer.java:
@Deprecated
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptParser.java:
@Deprecated
lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java: @Deprecated
lucene/highlighter/src/java/org/apache/lucene/search/highlight/TokenSources.java:
@Deprecated // maintenance reasons LUCENE-6445
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/LengthGoalBreakIterator.java:
@Deprecated
lucene/join/src/java/org/apache/lucene/search/join/BlockJoinSelector.java:
@Deprecated
lucene/misc/src/java/org/apache/lucene/misc/search/similarity/LegacyBM25Similarity.java:@Deprecated
lucene/misc/src/test/org/apache/lucene/misc/search/similarity/TestLegacyBM25Similarity.java:@Deprecated
lucene/suggest/src/java/org/apache/lucene/search/suggest/jaspell/JaspellLookup.java:@Deprecated
lucene/suggest/src/java/org/apache/lucene/search/suggest/jaspell/JaspellTernarySearchTrie.java:@Deprecated
lucene/suggest/src/test/org/apache/lucene/search/suggest/TestPersistence.java:
@Deprecated
```
Possibly some of these were only recently deprecated and should not be removed
for this release; I haven't checked carefully. Anyway it seems clear we won't
remove *all* @Deprecated annotations prior to a release. I shared my opinion
before that we should keep {{SynonymFilter}} and {{BrokenOffsetsFilter}}.
The branch had some fixes for {{BlockJoinSelector}} and {{TokenSources}} but
they didn't merge cleanly and looked big enough to me that maybe they deserve
their own PR's?
I think we can just remove the whole {{o.a.l.search.suggest.jaspell package}},
as well as {{LegacyBM25Similarity}}. I understand there might (?) still be a
Solr dependency on those, but with split build systems that shouldn't be a
blocker to remove.
The {{CharsRef}} thing looks longstanding and tricky to me; [~uschindler] do
you want to weigh in on that one?
The deprecations in the expressions package added by antlr seem kind of
unimportant and the root cause is not clear. Would we have to upgrade antlr or
something?
> Remove deprecated code in main
> ------------------------------
>
> Key: LUCENE-8638
> URL: https://issues.apache.org/jira/browse/LUCENE-8638
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Blocker
> Fix For: main (9.0)
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> There are a number of deprecations in master that should be removed. This
> issue is to keep track of deprecations as a whole, some individual
> deprecations may require their own issues.
>
> Work on this issue should be pushed to the `master-deprecations` branch on
> gitbox
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
