goankur commented on a change in pull request #282:
URL: https://github.com/apache/lucene/pull/282#discussion_r706532667
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java
##########
@@ -159,13 +160,15 @@ private FacetResult getDim(String dim, OrdRange ordRange,
int topN) throws IOExc
final MatchingDocs hits;
final OrdinalMap ordinalMap;
final int segOrd;
+ final Bits liveDocs;
public CountOneSegment(
LeafReader leafReader, MatchingDocs hits, OrdinalMap ordinalMap, int
segOrd) {
this.leafReader = leafReader;
this.hits = hits;
this.ordinalMap = ordinalMap;
this.segOrd = segOrd;
+ this.liveDocs = (leafReader != null) ? leafReader.getLiveDocs() : null;
Review comment:
Yes that makes sense. I made the change in the new revision captured in
a different PR
https://github.com/apache/lucene/pull/293
I had to create the new PR of a different branch as changes in a local
branch got overwritten after a rebase from remote, likely due to some GIT
related mistakes I made.
I'd request you to move our conversation over to the new PR. Apologies for
the inconvenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
