goankur commented on a change in pull request #282:
URL: https://github.com/apache/lucene/pull/282#discussion_r706535368
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java
##########
@@ -272,7 +273,8 @@ private void count(FacetsCollector facetsCollector) throws
IOException {
// Assuming the state is valid, ordinalMap should be null since we have
one segment:
assert ordinalMap == null;
- countOneSegment(docValues, hits.context.ord, hits);
+ // hits contain live documents only, no need to pass live docs bitset
explicitly
+ countOneSegment(docValues, hits.context.ord, hits, null);
Review comment:
Please see my earlier comments. Thanks for taking a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
