jtibshirani commented on a change in pull request #736: URL: https://github.com/apache/lucene/pull/736#discussion_r828316628
########## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ########## @@ -278,7 +287,21 @@ private BoundedDocSetIdIterator getDocIdSetIterator( } int lastDocIdExclusive = high + 1; - return new BoundedDocSetIdIterator(firstDocIdInclusive, lastDocIdExclusive, delegate); + Object missingValue = sortField.getMissingValue(); Review comment: It feels surprising to be checking deletions here, since it's not relevant to the query case -- maybe we could pull that into the `count` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org