jtibshirani commented on a change in pull request #736:
URL: https://github.com/apache/lucene/pull/736#discussion_r828339904
##########
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##########
@@ -306,14 +329,14 @@ private static ValueComparator loadComparator(
* A doc ID set iterator that wraps a delegate iterator and only returns doc
IDs in the range
* [firstDocInclusive, lastDoc).
*/
- private static class BoundedDocSetIdIterator extends DocIdSetIterator {
- private final int firstDoc;
- private final int lastDoc;
+ private static class BoundedDocIdSetIterator extends DocIdSetIterator {
+ protected final int firstDoc;
+ protected final int lastDoc;
private final DocIdSetIterator delegate;
- private int docID = -1;
+ protected int docID = -1;
Review comment:
I think this could still be private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
